ambition should use 'is' for NULL instead of ==
Reported by David Chelimsky | 2007-08-30 06:22:01 UTC
This statement:
LanguageElement.select{|e| e.parent_id == nil}
produces this:
SELECT * FROM language_elements WHERE (language_elements.`parent_id` = NULL)
but should produce this:
SELECT * FROM language_elements WHERE (language_elements.`parent_id` is NULL)
The attached patch makes it so.
Cheers,
David
Comments and changes to this ticket
-
-
-
David Chelimsky 2007-08-31 07:49:20 UTC
You're welcome. Just happens that the first thing I tried it on needed that :)
This is a really great idea Chris. In addition to making finders feel more like Ruby, it also 'feels' like (I could be dreaming here) it can go a long way to better decouple Rails' component layers. That's just an instinct. Maybe I'm crazy.
Anyhow, thanks for sharing this with the world, and thanks for accepting my patch :)
Cheers,
David
-
Chris Wanstrath 2007-08-31 12:41:01 UTC
- State changed from “resolved” to “open”
Hey, thanks for the patch.
I'm reopening this bug as a 'note to self' because I need to add IS NOT NULL.
-
Chris Wanstrath 2007-09-01 15:26:36 UTC
- State changed from “open” to “resolved”
Okay, fixed that up in http://projects.require.errthebl...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Chris Wanstrath