51
0
false
2009-02-23T11:10:22-08:00
25969
250
will_paginate-mangles-object-ids-if-named_scope-includes-a-join
101
466
new
will_paginate
Will_paginate mangles object ids if named_scope includes a :join
2009-02-23T11:16:23-08:00
25969
Adam Florin
Adam Florin
Chris Wanstrath
http://err.lighthouseapp.com/projects/466/tickets/250
It looks like if you use will_paginate in conjunction with an ActiveRecord named_scope with a :join, will_paginate will jam the ids of the joined table in place of the actual ids of the returned objects. Kinda hard to explain; it's a weird bug.
I'll pull an example from our source. Take two models, Review and Story, where Review belongs_to :story. If I set up a simple named scope like:
@@@
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {:status => 'visible'}
end
@@@
and then do:
@@@
Review.visible.paginate(:page => 1)
@@@
All the returned reviews are OK.
However, if I just add a join to that named_scope (perfectly legal) like:
@@@
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {'reviews.status' => ['list', 'feature']},
:joins => "JOIN stories ON reviews.story_id=stories.id"
end
@@@
...and then run the same paginate call as above, my results look like:
@@@
[#<Review id: 182, story_id: 182>, #<Review id: 183, story_id: 183>, ...]
@@@
Where the story_ids are all correct and the Review ids are all incorrectly set to match the story ids.
This has to do with how will_paginate or something is parsing the SQL results (which are correct). Note that if I feed an explicit :select to paginate like :select => "reviews.id, reviews.story_id", then the ids _are_ correct.
It looks like if you use will_paginate in conjunction with an ActiveRecord named_scope with a :join, will_paginate will jam the ids of the joined table in place of the actual ids of the returned objects. Kinda hard to explain; it's a weird bug.
I'll pull an example from our source. Take two models, Review and Story, where Review belongs_to :story. If I set up a simple named scope like:
@@@
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {:status => 'visible'}
end
@@@
and then do:
@@@
Review.visible.paginate(:page => 1)
@@@
All the returned reviews are OK.
However, if I just add a join to that named_scope (perfectly legal) like:
@@@
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {'reviews.status' => ['list', 'feature']},
:joins => "JOIN stories ON reviews.story_id=stories.id"
end
@@@
...and then run the same paginate call as above, my results look like:
@@@
[#<Review id: 182, story_id: 182>, #<Review id: 183, story_id: 183>, ...]
@@@
Where the story_ids are all correct and the Review ids are all incorrectly set to match the story ids.
This has to do with how will_paginate or something is parsing the SQL results (which are correct). Note that if I feed an explicit :select to paginate like :select => "reviews.id, reviews.story_id", then the ids _are_ correct.
<div><p>It looks like if you use will_paginate in conjunction with an
ActiveRecord named_scope with a :join, will_paginate will jam the
ids of the joined table in place of the actual ids of the returned
objects. Kinda hard to explain; it's a weird bug.</p>
<p>I'll pull an example from our source. Take two models, Review
and Story, where Review belongs_to :story. If I set up a simple
named scope like:</p>
<pre><code>
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {:status => 'visible'}
end
</code></pre>
<p>and then do:</p>
<pre><code>
Review.visible.paginate(:page => 1)
</code></pre>
<p>All the returned reviews are OK.</p>
<p>However, if I just add a join to that named_scope (perfectly
legal) like:</p>
<pre><code>
class Review < ActiveRecord::Base
named_scope :visible, :conditions => {'reviews.status' => ['list', 'feature']},
:joins => "JOIN stories ON reviews.story_id=stories.id"
end
</code></pre>
<p>...and then run the same paginate call as above, my results look
like:</p>
<pre><code>
[#<Review id: 182, story_id: 182>, #<Review id: 183, story_id: 183>, ...]
</code></pre>
<p>Where the story_ids are all correct and the Review ids are all
incorrectly set to match the story ids.</p>
<p>This has to do with how will_paginate or something is parsing
the SQL results (which are correct). Note that if I feed an
explicit :select to paginate like :select => "reviews.id,
reviews.story_id", then the ids <em>are</em> correct.</p></div>
192
3
true
2008-10-10T18:12:41-07:00
15346
247
use-namedscope-plugin
99
466
resolved
named_scope will_paginate
Use NamedScope Plugin
2008-10-26T17:42:25-07:00
15346
Ken Collins
Ken Collins
Mislav
http://err.lighthouseapp.com/projects/466/tickets/247
While using WillPaginate along with it's NamedScope patch to help me prepare a rather large app migration from rails 1.2.6 to the latest 2.1.1, I found many problems with the back port of NamedScope.
I created a well tested plugin on my Github account here:
http://github.com/metaskills/named_scope/tree/master
This backport plugin is very detailed and even includes a few extra backports like (first|last|all) on ActiveRecord::Base. It even includes patches for attribute conditions where you can pass in association collection and/or named scopes as conditions to other queries in turn generating the correct IN (?) sql syntax.
The plugin is very well tested too, in fact it includes all of the rails 2.1.1 tests for NamedScope that have been rewritten in shoulda/factory_girl. I have implemented this plugin into will_paginate/named_scope and accounted for one test that I think will never work in rails 1.2.6. Thoughts?
BTW, all tests are passing in all versions and DBs via rake test_all.
While using WillPaginate along with it's NamedScope patch to help me prepare a rather large app migration from rails 1.2.6 to the latest 2.1.1, I found many problems with the back port of NamedScope.
I created a well tested plugin on my Github account here:
http://github.com/metaskills/named_scope/tree/master
This backport plugin is very detailed and even includes a few extra backports like (first|last|all) on ActiveRecord::Base. It even includes patches for attribute conditions where you can pass in association collection and/or named scopes as conditions to other queries in turn generating the correct IN (?) sql syntax.
The plugin is very well tested too, in fact it includes all of the rails 2.1.1 tests for NamedScope that have been rewritten in shoulda/factory_girl. I have implemented this plugin into will_paginate/named_scope and accounted for one test that I think will never work in rails 1.2.6. Thoughts?
BTW, all tests are passing in all versions and DBs via rake test_all.
<div><p>While using WillPaginate along with it's NamedScope patch to
help me prepare a rather large app migration from rails 1.2.6 to
the latest 2.1.1, I found many problems with the back port of
NamedScope.</p>
<p>I created a well tested plugin on my Github account here:
<a href="http://github.com/metaskills/named_scope/tree/master">http://github.com/metaskills/nam...</a></p>
<p>This backport plugin is very detailed and even includes a few
extra backports like (first|last|all) on ActiveRecord::Base. It
even includes patches for attribute conditions where you can pass
in association collection and/or named scopes as conditions to
other queries in turn generating the correct IN (?) sql syntax.</p>
<p>The plugin is very well tested too, in fact it includes all of
the rails 2.1.1 tests for NamedScope that have been rewritten in
shoulda/factory_girl. I have implemented this plugin into
will_paginate/named_scope and accounted for one test that I think
will never work in rails 1.2.6. Thoughts?</p>
<p>BTW, all tests are passing in all versions and DBs via rake
test_all.</p></div>
192
0
true
2008-06-25T07:17:15-07:00
24430
232
systemstackerror-stack-level-too-deep
95
466
invalid
will_paginate
SystemStackError: stack level too deep
2008-10-26T02:32:11-07:00
192
Mislav
Jeannette
Mislav
http://err.lighthouseapp.com/projects/466/tickets/232
Hi all,
I got this error on script/console is there any fix ? Below are print stack:
>> @p = Person.find(106)
=> #<Person id: 106, createdate: "2001-01-17 19:34:19", firstname: "Peter">
>> @p.paper
=> [#<Paper id: 1246, title: "I", summary: nil>, #<Paper id: 968, title: "W", summary: nil>, #<Paper ident: 923, title: "S",summary: nil>, #<Paper id: 1200, >.....]
>> @p.paper.size
=> 94
>> @p.paper.class
SystemStackError: stack level too deep
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:138:in `method_missing_without_paginate'
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:139:in `method_missing'
from (irb):3
my models associations:
Person
has_many :author
has_many :paper :through => :author
my environment:
ruby -v ==> ruby 1.8.6 (2007-09-24 patchlevel 111) [i686-darwin9.2.2]
rails -v ==> Rails 2.1.0
gem -v ==> 1.0.1
just Successfully installed mislav-will_paginate-2.3.2
Many thanks,
Jeannette
Hi all,
I got this error on script/console is there any fix ? Below are print stack:
>> @p = Person.find(106)
=> #<Person id: 106, createdate: "2001-01-17 19:34:19", firstname: "Peter">
>> @p.paper
=> [#<Paper id: 1246, title: "I", summary: nil>, #<Paper id: 968, title: "W", summary: nil>, #<Paper ident: 923, title: "S",summary: nil>, #<Paper id: 1200, >.....]
>> @p.paper.size
=> 94
>> @p.paper.class
SystemStackError: stack level too deep
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:138:in `method_missing_without_paginate'
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:139:in `method_missing'
from (irb):3
my models associations:
Person
has_many :author
has_many :paper :through => :author
my environment:
ruby -v ==> ruby 1.8.6 (2007-09-24 patchlevel 111) [i686-darwin9.2.2]
rails -v ==> Rails 2.1.0
gem -v ==> 1.0.1
just Successfully installed mislav-will_paginate-2.3.2
Many thanks,
Jeannette
<div><p>
Hi all,
</p><p>
I got this error on script/console is there any fix ? Below are print stack:
</p><p>
>> @p = Person.find(106)
</p><p>
=> #
</p><p>
>> @p.paper
</p><p>
=> [#, #, #, #.....]
</p><p>
>> @p.paper.size
</p><p>
=> 94
</p><p>
>> @p.paper.class
</p><p>
SystemStackError: stack level too deep
</p><p>
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:138:in `method_missing_without_paginate'
</p><p>
from /Users/jc/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:139:in `method_missing'
</p><p>
from (irb):3
</p><p>
my models associations:
</p><p>
Person
</p><p>
has_many :author
</p><p>
has_many :paper :through => :author
</p><p>
my environment:
</p><p>
ruby -v ==> ruby 1.8.6 (2007-09-24 patchlevel 111) [i686-darwin9.2.2]
</p><p>
rails -v ==> Rails 2.1.0
</p><p>
gem -v ==> 1.0.1
</p><p>
just Successfully installed mislav-will_paginate-2.3.2
</p><p>
Many thanks,
</p><p>
Jeannette
</p></div>