Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Activity (RSS)

Monday, December 24 2007
22 Paginate view helpers was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 7:26 PM

    resolved in [426]

154 [PATCH] Improvements including custom link rendering was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 6:41 PM

    Hey Chewi~

    Thanks for the suggestions. In a recent change I've changed the way @template.params are extracted, so I think now you can be sure they are not clo...

91 Optional Previous and Next links was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 5:41 PM

    Thanks for the suggestion, but I'm determined to keep prev/next links because they are the most important element to pagination. I will never make an option to...

119 helper issue when request.method != :get was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 4:36 PM

    Hey Matt, Fjan,

    In changeset [422] I've stopped preserving parameters in pagination links for non-GET requests. So, obviously I listened to Matt's suggestion....

157 Support for custom renderer was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 4:33 PM

    Changeset [423] adds support for a custom renderer.

Sunday, December 23 2007
124 Change page_link_or_span api to take options was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 6:20 PM

    I'm closing this ticket in favor of #165, which would solve all your problems. Watch that ticket for updates from me.

129 will_paginate should make sure that the page param is an integer was updated
  • Mislav
    • State changed from invalid to resolved
    by Mislav at 3:26 PM

    In revision [421], WillPaginate::InvalidPage error is thrown on invalid input in :page parameter. WillPaginate::Collection doesn't even accept nil as page valu...

156 [PATCH] Collection.create should handle nil page was updated
  • Mislav
    • State changed from invalid to resolved
    by Mislav at 3:26 PM

    In revision [421], WillPaginate::InvalidPage error is thrown on invalid input in :page parameter. WillPaginate::Collection doesn't even accept nil as page valu...

171 subtlety not responding to new svn request was updated
  • Dr Nic
    Dr Nic commented at 1:58 AM

    Still think its dead.

Wednesday, December 19 2007
165 [PATCH] custom link generation was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    by Chris Wanstrath at 1:29 PM
  • Mislav
    • State changed from new to open
    • Title changed from PATCH for will_paginate: custom link generation to [PATCH] custom link generation
    by Mislav at 7:07 AM

    Thanks! I wanted to do this for a long time now, this got me focused on the issue and I'll try applying it in several days. Hopefully the will_paginate helper ...

156 [PATCH] Collection.create should handle nil page was updated
  • Brad Greenlee
    Brad Greenlee commented at 1:12 PM

    Throwing an appropriate exception is fine. Letting it fall through to SQL as LIMIT -10 isn't good. Thanks for looking at it.

  • Mislav
    • State changed from open to invalid
    by Mislav at 6:37 AM

    In Ruby, try doing this:

    2 + "2"
    

    You'll get an error that String cannot be coerced into Fixnum. This is because Ruby is strictly typed and it won't try to d...

149 Problem with using complex joins was updated
  • BrianTheCoder
    BrianTheCoder commented at 9:28 AM

    I was trying to paginate a query on beast using will_paginate instead of paginator. The above code works for the formerly built in pagination for rails, but I...

  • Mislav
    Mislav commented at 7:51 AM

    I don't understand, what is the issue here? What is the error message? What SQL gets generated? What was expected? Thanks

148 Allow filtering of what params get serialized was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 7:25 AM

    Follow #119, I'll post updates about this issue there... You'll be able to control params in page links

162 Change controller name.. was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 7:25 AM

    Follow #119, I'll post updates about this issue there

163 Change controller name.. was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 7:25 AM

    Follow #119, I'll post updates about this issue there

161 order not honored with uniq was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 7:18 AM

    Hey Shirl,

    This is in fact your fault. You're mixing database operations with local ones (the uniq method on Arrays). This is not a good approach, since you a...

170 list mode enhancement was updated
  • Mislav
    • State changed from new to open
    • Title changed from will_paginate enhancement to list mode enhancement
    by Mislav at 6:24 AM

    Hi, thanks for the suggestion/patch!

    I've been planing to make a list mode for some time now, your code might help me to do it faster :)

168 [idea] Pageless pagination was updated
  • Mislav
    • State changed from new to open
    • Title changed from [PATCH] Pageless pagination to [idea] Pageless pagination
    by Mislav at 2:57 AM

    I liked the concept of pageless pagination ever since I've heard of it. Although your code is a bit too much application-specific stuff (especially JavaScript)...

167 Pageless pagination was updated
  • Mislav
    • State changed from new to invalid
    by Mislav at 2:48 AM
Tuesday, December 18 2007
171 subtlety not responding to new svn request was updated
Thursday, December 13 2007
156 [PATCH] Collection.create should handle nil page was updated
  • Brad Greenlee
    Brad Greenlee commented at 4:43 PM

    We just ran into this as well at Wesabe, when a bot checking for security holes started throwing all kinds of non-numeric values at page. Seems the easiest sol...

67 Ajax Support was updated
  • bdoyle
    bdoyle commented at 9:44 AM

    @Tom

    I had this same problem and I modified the will paginate code to take a url in the options and it's working great. In my template file I do something l...

  • Tom
    Tom commented at 8:41 AM

    The lowpro.js approach works great if you only have one pagination area on a page. But I have a couple of cases where I'd like to have more than one paginato...

Tuesday, December 04 2007
169 Simple belongs_to && variants optimization was updated
  • Chris Wanstrath
    • State changed from new to open
    by Chris Wanstrath at 12:11 PM
  • Lourens Naude
    Lourens Naude created the ticket at 1:24 AM

    Chris,

    We're using these monkey patches in pre-production ... almost 0 overhead with regards to model changes and works well alongside non cached Models .... ...

Friday, November 30 2007
166 Remove ORDER BY clause for COUNT(*) version of query was updated
  • Cody Caughlan
    Cody Caughlan created the ticket at 12:17 PM

    When using paginate_by_sql it was not stripping out my ORDER BY clause in the COUNT(*) version of my query. In my case, the ORDER BY clause adds a lot of overh...

165 Custom link generation with a proc was updated
  • Hongli Lai
    Hongli Lai created the ticket at 10:33 AM

    The standard links that will_paginate generates do not serve my needs. This patch makes it possible to pass a block to will_paginate() for custom link generati...

Thursday, November 29 2007
164 Only delete tables that are not ignored was updated
  • Jeremy Lightsmith
    Jeremy Lightsmith created the ticket at 3:51 PM

    Didn't have time to create an actual patch, but in

    lib/scenario_builder.rb

    at line 80, instead of

    def delete_tables

    ActiveRecord::Base.connection.tables.ea...

Wednesday, November 28 2007
162 Change controller name.. was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Chris Wanstrath at 1:55 AM
163 Change controller name.. was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Chris Wanstrath at 1:55 AM
Tuesday, November 27 2007
163 Change controller name.. was updated
  • kilo
    kilo created the ticket at 11:55 PM

    Is it possible to change a controller name in will_paginate links?

162 Change controller name.. was updated
  • kilo
    kilo created the ticket at 11:54 PM

    Is it possible to change a controller name in will_paginate links?

Sunday, November 25 2007
76 Core changes in fragment_cache.rb was updated
  • Dylan Stamat
    Dylan Stamat commented at 4:55 PM

    Awesome, thanks Will :) Chris, could you check it out and possibly apply or reopen ? Thanks !

  • Will Bryant
    Will Bryant commented at 4:15 PM

    Hmm, didn't mean to remove that blank line in the middle there, leave that out of the patch :)

  • Will Bryant
    Will Bryant commented at 4:10 PM

    How about:

    --- old-connect-2/vendor/plugins/cache_fu/lib/acts_as_cached/fragment_cache.rb  2007-11-26 13:08:39.000000000 +1300
    +++ new-connect/vendor/plugins...
Thursday, November 22 2007
159 Gibberish.current_language= "" and friends should not complain was updated
160 Gibberish.current_language="" and friends should not complain was updated
161 order not honored with uniq was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Chris Wanstrath at 12:09 PM
  • sjh
    sjh created the ticket at 10:27 AM

    in a controller, I have this code

    @movies = @person.movies.uniq.paginate :page => params[:page], :order => params[:sort]

    but the :order statement in not hono...

Wednesday, November 21 2007
111 Task Body Missing was updated
  • Nate
    Nate commented at 9:24 PM

    It doesn't affect me now, and I never debugged it. So, since there's no way to recreate it you can probably close this. Oh, and where is sakebar now?

Tuesday, November 20 2007
156 [PATCH] Collection.create should handle nil page was updated
  • martin
    martin commented at 11:18 PM

    On a related note, both versions don't handle existing, non-nil but non-numerical values of page.

    E.g. if someone accesses /.../index?page=Wurstbrot this will...

Friday, November 16 2007
145 [patch] XFN additions was updated
  • Steve Ivy
    Steve Ivy commented at 7:32 PM

    FYI, this patch is out-of-date. I've made significant changes to the code and added "prev" link support as well. Once I manage to get my tests running I'll pos...

158 [patch] me.should.be.instance_of Array is a bug was created
  • Steve Ivy
    Steve Ivy created the ticket at 6:52 PM

    I've been trying to track down what I thought was a bug in some changes to mofo that I'm working on, but I'm starting to think it's a bug in the xfn tests.

    Af...

Wednesday, November 14 2007
157 Support for custom renderer was updated
  • Mislav
    • State changed from new to open
    by Mislav at 11:05 AM

    Yup---That is my intention.

  • Kamal Fariz
    Kamal Fariz created the ticket at 1:57 AM

    I've hacked up a Facebook-style pagination renderer for will_paginate for a Facebook app I'm developing. Would it be possible to allow a :renderer option to be...

Tuesday, November 13 2007
156 [PATCH] Collection.create should handle nil page was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Chris Wanstrath at 6:43 PM
  • Grant Rodgers
    Grant Rodgers created the ticket at 5:04 PM

    (sorry, sql is oracle)

    The paginate finder handles a nil value for page:

    Company.paginate(:page => nil, :per_page => 10)
    => select * from (select raw_sql_.*...