Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Activity (RSS)

Tuesday, October 09 2007
117 Illegal MySQL in #to_sql and #to_hash was updated
  • Allan Cochrane
    Allan Cochrane commented at 4:00 PM

    On reflection, I'm not sure it's got much to do with changing table names, because that part seems to be correct:

    From script/console:

    >> Project.table_name

    ...

  • Chris Wanstrath
    Chris Wanstrath commented at 2:14 PM

    Can you post some of the ActiveRecord code you had to write in order to get your legacy DB working? set_table_name and all that? Ideally I'd like to add it t...

127 Rake task names/namespaces out of order was updated
  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to PJ Hyett
    • State changed from new to open
    by Chris Wanstrath at 1:38 PM
  • David Dollar
    David Dollar created the ticket at 11:38 AM

    db:auto:migrate should be db:migrate:auto since auto modifies migrate

    patch is attached

    sorry if this is a duplicate, lighthouse seems to keep marking this a...

115 Support migration-based automatic versioning was updated
Sunday, October 07 2007
Will Paingate dox spellcheck ftw htt... was committed by Chris Wanstrath at 12:33 PM
Will Paginate: more dox for WP::Colle... was committed by Chris Wanstrath at 12:28 PM
120 Association with finder_sql raises TypeError was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 12:04 PM

    I've given it a go, but it seems too hard to support right now. Fixing ActiveRecord would be involved and I'm not sure if I should do it.

    So, if you have manu...

79 include :select if it begins with 'DISTINCT' was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 11:42 AM

    Done in [403]

Will Paginate: include :select param ... was committed by Chris Wanstrath at 11:41 AM
85 failures linked to association extensions was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 9:23 AM

    Doh! You're using it all wrong. Do something like this

      has_many :prints, :through=> :taggings, :source=> :print, :uniq=>true do
        def find_for_user(user,...
has_many :through and association ext... was committed by Chris Wanstrath at 9:18 AM
db schema in Ruby http://plugins.req... was committed by Chris Wanstrath at 6:51 AM
start making unit test demonstrations... was committed by Chris Wanstrath at 6:26 AM
Saturday, October 06 2007
Dox tweaks + link to Railscast http:... was committed by Chris Wanstrath at 5:46 PM
cleanup the mess with parameters in t... was committed by Chris Wanstrath at 5:10 PM
Refactor will_paginate helper to Will... was committed by Chris Wanstrath at 4:57 PM
125 handling an out of range page number was updated
  • Mislav
    Mislav commented at 11:44 AM

    Blah, Lighthouse didn't pick up changeset 393 properly ... see it here: http://plugins.require.errtheblo...

  • Mislav
    • State changed from new to resolved
    by Mislav at 11:44 AM

    In [393] I have added an "out_of_bounds?" method that returns true in conditions you've described. You can use it to decide what to do in your controllers or w...

reorganize some tests; add new ones f... was committed by Chris Wanstrath at 9:57 AM
Friday, October 05 2007
125 handling an out of range page number was updated
  • Fjan
    Fjan created the ticket at 11:06 AM

    If the user deletes the last item on the last page of a will_paginated list, the total number of pages will decrease by one. Therefore the next page to be disp...

119 helper issue when request.method != :get was updated
  • Mislav
    Mislav commented at 9:09 AM

    Fjan, I don't think I'll be supporting that practice, but will definitely make this configurable. You will be able to mess with merged parameters as much as yo...

Wednesday, October 03 2007
124 Change page_link_or_span api to take options was updated
  • Mislav
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Mislav at 9:02 PM

    Definitely coming. I'll be working on this soon

  • Rob Dupuis
    Rob Dupuis created the ticket at 2:47 AM

    This is a feature request to aid with overriding this method. I was wondering if the method signature for the page_link_or_span in view_helpers could be change...

Tuesday, October 02 2007
123 Need help downloading will_paginate was updated
  • Bence Golda
    Bence Golda commented at 12:20 PM

    You may face problems if you're behind a firewall that rejects svn traffic on 3690/tcp. Try to connect to the svn server manually (eg. with `telnet errtheblog...

  • Mislav
    • State changed from new to invalid
    by Mislav at 5:15 AM
Sunday, September 30 2007
123 Need help downloading will_paginate was updated
  • CassAmino
    CassAmino commented at 6:15 PM

    Hi,

    No problem, I just got the access to the repository and installed the plugin.

    Cheers

    Cass

  • CassAmino
    CassAmino created the ticket at 4:28 AM

    Hi,

    I am having severe trouble trying to install will_paginate, I keep getting this "unable to establish connection with host as the target machine actively r...

Saturday, September 29 2007
122 slice broken was updated
  • Chris Wanstrath
    • State changed from open to resolved
    by Chris Wanstrath at 10:35 AM

    Fixed by Yves Dufour!

  • Chris Wanstrath
    Chris Wanstrath created the ticket at 10:33 AM
    us = User.select { |u| u.id > 20 }.sort_by(&:id)[3, 5]
    => (Query object: call #to_sql or #to_hash to inspect, call an
    Enumerable (such as #each or #first) to ...
120 Association with finder_sql raises TypeError was updated
  • Mislav
    • State changed from new to open
    • Title changed from Paginate association with finder_sql raises TypeError to Association with finder_sql raises TypeError
    by Mislav at 2:09 AM

    Damn. Gotta investigate how this should/could work. Thanks for the report!

67 Ajax Support was updated
  • Mislav
    • State changed from open to invalid
    • Title changed from [Will Paginate][Patch] Ajax Support to Ajax Support
    by Mislav at 1:21 AM

    I agree with Matt. I kept this open to give me time to think in what way could I help Ajax pagination ... I realized that the user is on his own, because I'm d...

Friday, September 28 2007
120 Paginate association with finder_sql raises TypeError was updated
  • wildchild
    • Assigned user changed from Chris Wanstrath to Mislav
    by wildchild at 8:31 PM
  • wildchild
    wildchild created the ticket at 8:27 PM

    In case when finder_sql || counter_sql is used, attempt to paginate association raises TypeError: can't convert nil into Array

    Attached failing test case.

117 Illegal MySQL in #to_sql and #to_hash was updated
  • Allan Cochrane
    Allan Cochrane commented at 3:27 PM

    DB is MySQL.

    To illustrate:

    I'm expecting the result of

    FormalResult.find(:all, :conditions => {'module_name' =>"comfy"})

    to be the same as:

    FormalResult....

  • Chris Wanstrath
    • State changed from new to open
    by Chris Wanstrath at 12:34 PM

    Are you using ActiveRecord? What DB -- SQLite?

    Ambition should try to use your DB's quoting via the following code:

        def sanitize(value)
          if value....
67 [Will Paginate][Patch] Ajax Support was updated
  • Matt Aimonetti (mattetti)
    Matt Aimonetti (mattetti) commented at 12:52 PM

    I don't think the plugin itself should handle any ajax calls.

    simply use unobtrusive javascript and you can achieve the same result in less than 5 minutes wit...

108 not expected query in paginate association was updated
  • Chris Wanstrath
    • State changed from open to resolved
    by Chris Wanstrath at 12:31 PM

    Should be fixed by Mislav's latest round of changes.

90 paginate on an association loads the entire association before doing a count was updated
  • Chris Wanstrath
    • State changed from open to resolved
    by Chris Wanstrath at 12:30 PM

    Mislav fixed this.

Thursday, September 27 2007
[AutoMigrations] change_column fix fo... was committed by Chris Wanstrath at 5:41 PM
[AutoMigrations] Need to inspect the ... was committed by Chris Wanstrath at 4:49 PM
86 Will_paginate kills YAML fixtures with ERB was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 1:12 PM

    I'm using will_paginate with projects that have erb in yaml fixtures. No probs

Wednesday, September 26 2007
Will Paginate docs and contributors ... was committed by Chris Wanstrath at 7:08 PM
92 avoid doing count on last page was updated
  • Elijah Miller
    Elijah Miller commented at 6:20 PM

    That was a bit more involved than I expected!

    Thanks for the hard work!

  • Chris Wanstrath
    • State changed from open to resolved
    by Chris Wanstrath at 6:09 PM

    (from [388]) Will Paginate lazy counting! Counting is done after the SELECT, but skipped entirely if Finder figures out that this is the last page. We are talk...

Will Paginate lazy counting! Counting... was committed by Chris Wanstrath at 6:09 PM
109 repeat conditions in paginate association was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 4:30 PM

    Thanks. This was a glitch in AR that I've worked around. It may still happen in some rare cases, but is nothing to worry about.

Will Paginate cleanup http://plugins... was committed by Chris Wanstrath at 3:02 PM
116 :page => :last was updated
  • Eugene Pimenov
    Eugene Pimenov commented at 2:32 PM

    I understand about order :), but it reverses all entries.

    I just needed last page by default.

    Thanks for review anyway. I'll still use my version in this pro...

107 Option to Omit Page Numbers was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 2:08 PM

    Unfortunately, the count will always be required. Even if we don't render page numbers (just previous and next links), we have to know are there any other page...