Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Activity (RSS)

Thursday, August 30 2007
96 ambition: hard-coded MySQL syntax in WhereProcessor methods was updated
  • Matthew King
    Matthew King commented at 10:59 AM

    Here's a patch that adds a quote_column_name facade for the ActiveRecord connection to Processor, which is then used in WhereProcessor#translate.

    The patch ha...

  • Chris Wanstrath
    • State changed from new to open
    by Chris Wanstrath at 10:56 AM

    I thought RLIKE was MySQL-specific and REGEXP was SQL standard. Am I getting it backwards?

    Yes, Ambition was written for MySQL and ActiveRecord. But I don't...

  • Matthew King
    • Title changed from Hard-coded MySQL syntax in WhereProcessor methods to ambition: hard-coded MySQL syntax in WhereProcessor methods
    by Matthew King at 8:19 AM
  • Matthew King
    Matthew King created the ticket at 8:01 AM

    The SQL generated by the WhereProcessor has MySQL syntax baked in. So far, I've noticed backquotes to escape column names and the REGEX operator.

    The methods...

95 can't run tests for ambition was updated
  • Matthew King
    Matthew King commented at 8:48 AM

    Well, David, some of us are literate, and some of us just make wild assumptions and then post to public websites.

  • David Chelimsky
    David Chelimsky commented at 8:42 AM

    Matthew - thanks for the patch. And thanks for showing me where the rspec website is!

    Cheers,

    David Chelimsky

    Lead Developer

    RSpec Development Team

  • Matthew King
    Matthew King commented at 8:36 AM

    Patch to add simplest possible Rake::TestTask

  • Matthew King
    Matthew King commented at 8:25 AM

    Re: rspec.

    Actually not. Must look before leaping.

    The tests use test-spec:

    http://chneukirchen.org/blog/arc...

  • Matthew King
    Matthew King commented at 8:10 AM

    The tests use RSpec, starter instructions for which I found here:

    http://rspec.rubyforge.org/docum...

1 earlier change…
  • David Chelimsky
    David Chelimsky created the ticket at 6:26 AM

    I just grabbed ambition source and created a patch, but I had to create my own all_tests.rb file to run all the tests. For some reason, of which I have absolut...

98 Regexp expressions ignored was created
  • François Beausoleil
    François Beausoleil created the ticket at 8:09 AM

    Regular expression options (i for ignore case and so on) are ignored:

    Party.select {|p| p.display_name =~ /beausoleil/i}.to_sql
    

    Returns the following:

    "SEL...
97 #downcase maps previous call to a relationship was created
  • François Beausoleil
    François Beausoleil created the ticket at 8:06 AM
    Party.select {|p| p.display_name.downcase =~ "beausoleil%"}.to_sql
    

    Dies with a nice backtrace:

    RuntimeError: No reflection `display_name' found on Party
       ...
94 ambition should use 'is' for NULL instead of == was updated
  • David Chelimsky
    David Chelimsky commented at 6:48 AM

    Here's a better patch

  • David Chelimsky
    David Chelimsky created the ticket at 6:22 AM

    This statement:

    LanguageElement.select{|e| e.parent_id == nil}

    produces this:

    SELECT * FROM language_elements WHERE (language_elements.`parent_id` = NULL)

    ...

Wednesday, August 29 2007
ambition moving to projects http://... was committed by Chris Wanstrath at 7:40 PM
body_matcher: return an array of Body... was committed by Chris Wanstrath at 2:41 PM
Monday, August 27 2007
ambition: join tests http://plugins... was committed by Chris Wanstrath at 11:53 PM
ambition: simple joins, order uses ta... was committed by Chris Wanstrath at 11:41 PM
Attribution http://plugins.require.e... was committed by Chris Wanstrath at 11:32 PM
Update readme http://plugins.require... was committed by Chris Wanstrath at 11:30 PM
YUI on Rails http://plugins.require.... was committed by Chris Wanstrath at 11:18 PM
Will Paginate: more test coverage for... was committed by Chris Wanstrath at 3:49 PM
93 Combining associations and include fails was updated
  • Chris Wanstrath
    • State changed from open to invalid
    by Chris Wanstrath at 3:49 PM

    (from [341]) Will Paginate: more test coverage for combining association pagination with the :include option. The test fails with Rails 1.2.3, but the user is...

  • Matijs van Zuijlen
    Matijs van Zuijlen commented at 3:00 PM

    It seems this is due to Rails internals wiping out the :include option. I've fixed ActiveRecord::Associations::HasManyAssociation#count so the test passes[1], ...

  • Chris Wanstrath
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open
    by Chris Wanstrath at 9:04 AM
  • Matijs van Zuijlen
    Matijs van Zuijlen commented at 5:18 AM

    Here is a patch with tests revealing the problem. The first test tests that this works in the case of e.g. Workers.paginate, the second (failing) test tests th...

  • Matijs van Zuijlen
    Matijs van Zuijlen created the ticket at 5:13 AM

    In will_paginate, if a company has workers, and a worker has a car, something like

    company.workers.paginate(:page => 1, :include => :cars, :conditions => "car...

will_paginate: ignore :limit and :off... was committed by Chris Wanstrath at 2:24 PM
yield elements http://plugins.requi... was committed by Chris Wanstrath at 10:26 AM
gunner text tweaks http://plugins.r... was committed by Chris Wanstrath at 2:21 AM
gunner! http://plugins.require.errt... was committed by Chris Wanstrath at 2:12 AM
Friday, August 24 2007
no more 007 http://plugins.require.e... was committed by Chris Wanstrath at 3:13 PM
james_bond: suspects http://plugins... was committed by Chris Wanstrath at 3:06 PM
james_bond: few more tweakages, have ... was committed by Chris Wanstrath at 2:05 PM
jb tweaks http://plugins.require.er... was committed by Chris Wanstrath at 2:02 PM